Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Update Checker Workflow #6927

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Dependency Update Checker Workflow #6927

merged 1 commit into from
Jan 12, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 8, 2024

Maven dependency update hint analog, but for binaries-list files and put into a workflow. I used the util already for PRs like #6918 and thought this would have greater value when run by CI so others can use it too.

output looks like:

/home/runner/work/netbeans/netbeans/ide/libs.graalsdk/external/binaries-list
    org.graalvm.sdk:graal-sdk                          20.3.0 -> 23.1.1
    org.graalvm.sdk:launcher-common                    20.3.0 -> 23.1.1
...

see job summary or log for full output:
https://github.com/apache/netbeans/actions/runs/7442427492

workflow is currently configured to run only on manual dispatch (this will only work once merged to master). This means that it can be manually triggered from https://github.com/apache/netbeans/actions/workflows/dependency-checks.yml

btw: the very first version of this util generated temporary pom files for each module containing binaries-list and then ran mvn verify versions:display-dependency-updates, this is the more direct approach without extra steps which download half of the internet.

@mbien mbien added CI continuous integration changes ci:no-build [ci] disable CI pipeline labels Jan 8, 2024
@mbien mbien force-pushed the dep-checker branch 2 times, most recently from 2f69711 to 98b253d Compare January 8, 2024 02:44
Maven dependency update hint analog, but for binaries-list files and
put into a workflow.
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing, that instead of throwing a RuntimeException on errors, I'd just log a one liner, so the process would continue, instead of failing fast.

@mbien
Copy link
Member Author

mbien commented Jan 12, 2024

@lkishalmi my thought was that someone who is running the script via actions or locally, would probably restart it anyway if there are networking issues. If this happens to be a problem, we could add a retry loop there and then fail after 3 retries or so.

It is manually triggered, it won't run automatically in PRs or so that is why I think fail-fast is better there.

@mbien mbien added this to the NB21 milestone Jan 12, 2024
@mbien mbien merged commit 2229a9e into apache:master Jan 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:no-build [ci] disable CI pipeline CI continuous integration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants