Add support for Memfault commands#165
Add support for Memfault commands#165michal-narajowski wants to merge 1 commit intoapache:masterfrom
Conversation
michal-narajowski
force-pushed
the
memfault
branch
from
732b88d to
29fcc08
Compare
ccollins476ad
left a comment
ccollins476ad
left a comment
There was a problem hiding this comment.
Looks good to me. In addition to the minor comment I left, could you please run gofmt on the changed files?
newtmgr/cli/memfault.go
Outdated
| tmpName := args[0] + ".tmp" | ||
| progressBytes := 0 | ||
| file, err := os.OpenFile(tmpName, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0660) |
There was a problem hiding this comment.
ioutil.Tempfile() (https://golang.org/pkg/io/ioutil/#TempFile) would be slightly better here. If the user quits with ctrl-C, there won't be a temp file in the current directory.
|
Hello @michal-narajowski , are you interested in progressing this PR? |
https://memfault.com/ Adds support for pulling coredump data, events and traces from the device.
michal-narajowski
force-pushed
the
memfault
branch
from
29fcc08 to
dc6fe74
Compare
|
Hi @ddavidebor, I fixed mentioned in @ccollins476ad review. I can't test it anymore though. |
|
Do you have some instructions on how to use the feature?
…On Wed, 30 Mar 2022 at 13:12, Michał Narajowski ***@***.***> wrote:
Hi @ddavidebor <https://github.com/ddavidebor>, I fixed mentioned in
@ccollins476ad <https://github.com/ccollins476ad> review. I can't test it
anymore though.
—
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFC37RMSG77NWDQYVZWR7LVCRAL5ANCNFSM4NJPWM3A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I've done some research and it looks like my PR with support for Memfault has been scrapped. The feature has now been added to memfault repo: https://github.com/memfault/memfault-firmware-sdk/tree/master/ports/mynewt. I'm not sure but maybe you could still use it with these commands. You would also need apache/mynewt-mcumgr#84 since it implements the commands on the device side. Usage is rather simple (newtmgr memfault pull). Please refer to newtmgr docs: https://mynewt.apache.org/latest/os/modules/devmgmt/newtmgr.html |
3 participants
https://memfault.com/
Adds support for pulling coredump data, events and traces from
the device.