Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Updated build_doc.sh to build on the new release tag found #9896

Merged
merged 6 commits into from
Feb 27, 2018

Conversation

thinksanky
Copy link
Contributor

Description

  • Checked out the new release tag if found and do makes docs on it.
  • Rest of the logic stays same.
  • Added readable comments in many places so reader can follow the logic in the code.

@thinksanky
Copy link
Contributor Author

  • Testing:
    Currently building on ubuntu. I can see the extracted tag and building it when found, but the build itself is taking too long and freezing. Retrying build again. "make docs" is taking up a lot of memory and taking too long to run.

@aaronmarkham
Copy link
Contributor

I checked out your fork and ran the script using:
sudo docs/build_version_doc/build_doc.sh https://github.com/apache/incubator-mxnet-site asf-site
It created VersionedWeb folder with 1.0.0 as the default and 1.1.0 was not present.
Please provide details on how to run the script to get it to produce all of the tags.

@thinksanky
Copy link
Contributor Author

To run locally, I had to tweak the script to set
curr_tag=1.1.0 inside the script. The {TAG} value is coming from Jenkins when the Job is run and it picks the curr_tag:5 as well. I am not very clear from Jenkins job configuration, but these two lines in the script picks the latest tag:

curr_tag=${TAG}
curr_tag=${curr_tag:5}

But for manual testing I override this value

curr_tag=${TAG}
curr_tag=${curr_tag:5}
curr_tag=1.1.0 (... for example to force build 1.1.0 and test the logic)

@marcoabreu marcoabreu merged commit ada45fb into apache:master Feb 27, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* temporary fix to update the verionsioning of 1.1.0 that is skipped during build process

* updated build_doc.sh

* testing new updates of build_doc.sh

* fixed comments and syntax

* removed test data and comments
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* temporary fix to update the verionsioning of 1.1.0 that is skipped during build process

* updated build_doc.sh

* testing new updates of build_doc.sh

* fixed comments and syntax

* removed test data and comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants