Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Draw labels name #9496

Merged
merged 3 commits into from
Sep 12, 2018
Merged

Draw labels name #9496

merged 3 commits into from
Sep 12, 2018

Conversation

lvaleriu
Copy link
Contributor

@lvaleriu lvaleriu commented Jan 19, 2018

Draw labels name next to corresponding bounding boxes when the mapping of id to names is specified.

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@lvaleriu
Copy link
Contributor Author

Hello. Can someone help me with this? I dont understand why this commit cannot be built since the modifications are done only at python level (at a very precise place).
Thanks!

@zhreshold zhreshold self-assigned this Jan 31, 2018
@CodingCat
Copy link
Contributor

Hi, the community has passed to vote about associating the code changes with JIRA (https://lists.apache.org/thread.html/ab22cf0e35f1bce2c3bf3bec2bc5b85a9583a3fe7fd56ba1bbade55f@%3Cdev.mxnet.apache.org%3E)

We have updated the guidelines for contributors in https://cwiki.apache.org/confluence/display/MXNET/Development+Process, please ensure that you have created a JIRA at https://issues.apache.org/jira/projects/MXNET/issues/ to describe your work in this pull request and include the JIRA title in your PR as [MXNET-xxxx] your title where MXNET-xxxx is the JIRA id

Thanks!

@szha
Copy link
Member

szha commented May 9, 2018

@lvaleriu ping. Could you do a rebase?

@lvaleriu
Copy link
Contributor Author

Yes!

@szha
Copy link
Member

szha commented Jun 30, 2018

@lvaleriu pinging for a rebase. Since there's no merge conflict, it would be great if you could do:

git remote add upstream https://github.com/apache/incubator-mxnet
git pull upstream master --rebase
git push --force

After the rebase, this PR will be verified by our updated CI. Thanks.

@lupesko
Copy link
Contributor

lupesko commented Aug 6, 2018

@lvaleriu rebounce: can you please do a rebase?

@lvaleriu
Copy link
Contributor Author

lvaleriu commented Aug 6, 2018

Done! @lupesko @szha

@lupesko
Copy link
Contributor

lupesko commented Aug 28, 2018

@lvaleriu looks like you have sanity test failing: RAT (licensing) and lint - kindly take a look at the Jenkins output.
@marcoabreu any guidance you can provide about RAT check failing?

@lupesko
Copy link
Contributor

lupesko commented Sep 11, 2018

@lvaleriu bouncing - you have sanity test failing: RAT (licensing) and lint - kindly take a look at the Jenkins output.

@lvaleriu
Copy link
Contributor Author

I'm still trying to understand what is the RAT licensing thing.

@zhreshold
Copy link
Member

@lvaleriu please remove the c++ files, they are no longer required by SSD networks. And by doing this, you are free from the RAT license issue.

Draw labels name next to corresponding bounding boxes when the mapping of id to names is specified.
@lvaleriu
Copy link
Contributor Author

Hope this will do it!
@zhreshold Thanks!

Fixed missing variable declaration
Fixing lint issues
@zhreshold zhreshold merged commit 6456687 into apache:master Sep 12, 2018
@zhreshold
Copy link
Member

Resolved, thanks for contribution @lvaleriu

anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* Draw labels name

Draw labels name next to corresponding bounding boxes when the mapping of id to names is specified.

* Update detection.py

* Update detection.py
Fixed missing variable declaration
Fixing lint issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants