-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This reverts commit 6c1f4f7.
how about put "experimental text api in 1.0.1", especially given it has no conflict with other modules. This PR is needed for the mooc class next week. |
Let's have the discussion happen first. |
I think @piiswrong 's concern is that if we put this module into So one way is rename @piiswrong If this is what you thought. I believe instead of reverting this PR, a better way to communicate is
|
This, plus there are naming issues that needs more review. Plus rolling back is usually better than fixing forward. We should rollback this as soon as possible before someone starts depending on it. |
@astonzhang Please resubmit to contrib. |
@piiswrong agreed to move to contrib. I will merge this PR and resubmit. |
This reverts commit 6c1f4f7.
This reverts commit 6c1f4f7.
This reverts commit 6c1f4f7.
This reverts commit 6c1f4f7.
This reverts commit 6c1f4f7.
This is a major addition in API and needs more discussion.
Also it should wait after 1.0.1 release
Description
(Brief description on what this PR is about)
Checklist
Essentials
make lint
)Changes
Comments