-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
hmm, @piiswrong could you tell more detail about why closing this? |
@iblis17 Oh sorry for that, lets review this from scratch, what do you think? I see a few issues with your proposed approach. During build, you're checking out another repository that is not in sync with this repo. Is it possible to auto-generate the structure the structure Julia expects? If that's possible, I'd propose that as part of testing, we generate the appropriate Julia environment on CI and then run tests on top of that - no checkout of another repository happens that way. |
Additionally, we could create a job on CI that automatically keeps the Julia repo in sync with the main repo - e.g. copying all commits to the Julia Repo. |
Let me tell more about my approach. Julia's package manager is
So, yeah,
(Yes, but) It's only possible for testing/dev purpose. For releasing a package, you still need a standalone repo to let user e.g. % cd ~/.julia/v0.6 && ln -s ~/dev/mxnet/julia MXNet
So, you propose that moving all Julia related development to this repo, and treat |
Since the Julia requires its own dedicated GitHub repository, I propose that all Julia-related development gets moved into this repository and that we run a CI job that compiles MXNet and Julia packages and then publishes it to a new repository, e.g. incubator-mxnet-julia. Users would close off that repository while actual development happens in incubator-mxnet. I'm totally unfamiliar with Julia, so please bare with me if there's a mistake in my thought-process. |
I agree your thought-process.
I want that we keep using the original
I prefer to have a standalone issue tracker for Julia stuffs, as the status quo. I can keep eye on it, if user open issue on it. (Watching this repo is too noisy for me.) Also, If we move dev to this repo, there are some issues I want to check:
|
Having MXNet.jl being part of the main |
It will also be possible with the next major release of Julia and the new
package manager to install packages that are not primary repositories.
Which means that in the long-term we can deprecate the MXNet.jl repository.
…On Tue, 27 Feb 2018 at 16:03 Valentin Churavy ***@***.***> wrote:
Having MXNet.jl being part of the main incubator-mxnet would actually be
helpful, since their have been issues in the past with keeping the code
synchronised. I would propose that we do a git subtree import of MXNet.jl
into incubator-mxnet/julia
We can then use the git subtree mechanism to push changes to MXNet.jl and
tag releases that way.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8727 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI3akkPGnRoHLiVEMQtr6WG5iAdSuZsks5tZG1-gaJpZM4Qkij_>
.
|
Would you be fine with that repo being a mirror of the Apache repository?
We are make use of the tagging feature and label each issue according to the language binding. In future (see the current vote thread on dev@), we will make use of Jira. This should give you all the tools and overview you need.
At the moment, every language binding shares the same release cycle as MXNet itself. I agree that this is not optimal and I'd be happy to see some improvements in that direction.
From a first clance it seems like it is not too complicated to migrate to a Sphinx compatible layout, but I could underestimate the required effort. Do you think this would be an issue?
I have to check back, but since you three are putting a lot of time and effort into supporting MXNet, I don't see many issues there. I'm unfamiliar with the Apache process if two projects get merged, but I'm sure we will find a solution. Generally, this sounds like a discussion we should involve the community into. Would you mind creating a thread on dev@? In the meantime, I will check back about the committership. |
yeah, mirroring to that repo sounds good to me.
👍
Well, I have no idea about any detail of Sphinx at all.
Ok, will do. |
I think it is OK to keep the development in the main repo side: either way seems to have trade offs. I guess the important thing is to keep both sides in sync. Currently hard constraints is that the Julia package should be in a separate repo (being a mirror or not). As for documents, sphinx might work but there might be some extra work to make the dynamically generated doc work. Also I see a much less motivation to merge and migrate the docs. The original setup should still work, right? |
yeah, the easiest solution is just keeping the original setup; keeping travis build and auto-deployment. |
ci-test
branchcc @mbaijal