WIP: Operator tuning #8670

cjolivier01 · 2017-11-15T18:43:23Z

@piiswrong

Description

Operator tuning

Checklist

Essentials

Passed code style checking (make lint)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage
For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented.
To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Feature1, tests, (and when applicable, API doc)
Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cjolivier01 · 2017-11-15T18:44:08Z

src/operator/tensor/elemwise_binary_broadcast_op.h

-            s, new_oshape.Size(), req[0], lstride, rstride, oshape,
-            inputs[0].dptr<DType>(), inputs[1].dptr<DType>(), outputs[0].dptr<DType>(),
-            inputs[0].Size(), inputs[1].Size());
+        mshadow::Shape<NDim> oshape = new_oshape.get<NDim>();


My IDE (CLion) isn't very good at matching up namespaces

cjolivier01 · 2017-11-16T19:46:52Z

Real PR: #8686

Refreshed branch bc_tune

884a90e

cjolivier01 closed this Nov 15, 2017

cjolivier01 commented Nov 15, 2017

View reviewed changes

cjolivier01 changed the title ~~Refreshed branch bc_tune~~ Operator tuning Nov 15, 2017

cjolivier01 changed the title ~~Operator tuning~~ WIP: Operator tuning Nov 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Operator tuning #8670

WIP: Operator tuning #8670

cjolivier01 commented Nov 15, 2017 •

edited

Loading

cjolivier01 Nov 15, 2017

cjolivier01 commented Nov 16, 2017

WIP: Operator tuning #8670

WIP: Operator tuning #8670

Conversation

cjolivier01 commented Nov 15, 2017 • edited Loading

Description

Checklist

Essentials

Changes

Comments

cjolivier01 Nov 15, 2017

Choose a reason for hiding this comment

cjolivier01 commented Nov 16, 2017

cjolivier01 commented Nov 15, 2017 •

edited

Loading