Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add swapaxis operator into mxnet #519

Merged
merged 5 commits into from
Nov 10, 2015
Merged

add swapaxis operator into mxnet #519

merged 5 commits into from
Nov 10, 2015

Conversation

starimpact
Copy link
Contributor

No description provided.

namespace mxnet {
namespace op {

struct SwapAxis{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to namespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change struct SwapAxis to namespace SwapAxis {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually change to name space wilI need small captital letter
On Sun, Nov 8, 2015 at 10:11 PM Zhang Ming [email protected] wrote:

In src/operator/swapaxis-inl.h
#519 (comment):

+#define MXNET_OPERATOR_SWAPAXIS_INL_H_
+
+#include <dmlc/logging.h>
+#include <dmlc/parameter.h>
+#include <mxnet/operator.h>
+#include
+#include
+#include
+#include
+#include
+#include "./operator_common.h"
+
+namespace mxnet {
+namespace op {
+
+struct SwapAxis{

what do you mean?


Reply to this email directly or view it on GitHub
https://github.com/dmlc/mxnet/pull/519/files#r44243657.

@tqchen
Copy link
Member

tqchen commented Nov 9, 2015

Thanks! I have last few comments. I will merge it after these are fixed.

@starimpact
Copy link
Contributor Author

everything is ok now!

@starimpact
Copy link
Contributor Author

Failed ?

@tqchen
Copy link
Member

tqchen commented Nov 9, 2015

There was a lint error, in the header file. You will need to change the namespace SwapAxis to small capital letter swapaxis, and add space between swapaxies and {, like swapaxis {

@starimpact
Copy link
Contributor Author

ok, I fix it now.

@tqchen
Copy link
Member

tqchen commented Nov 10, 2015

One last thing, break https://travis-ci.org/dmlc/mxnet/jobs/90038655#L986 the line to two lines

@starimpact
Copy link
Contributor Author

no lint problem now!

tqchen added a commit that referenced this pull request Nov 10, 2015
add swapaxis operator into mxnet
@tqchen tqchen merged commit 9d1abbf into apache:master Nov 10, 2015
@tqchen
Copy link
Member

tqchen commented Nov 10, 2015

Cool! Thanks for being patient, this is now merged

@starimpact
Copy link
Contributor Author

😅

@starimpact
Copy link
Contributor Author

I want to join yours and contribute more.
I found there is a similar tool named tensorflow.

@starimpact
Copy link
Contributor Author

hello?

@XericZephyr
Copy link
Contributor

I tend to say the Tensorflow is more like mshallow. @tqchen
Google doesn't seem to open-source the distributed training part.

BTW, is the SwapAxis operator used to 'transpose' the tensor like the numpy do? @starimpact

@starimpact
Copy link
Contributor Author

sure, it's just like the numpy's swapaxes function.

@tqchen
Copy link
Member

tqchen commented Nov 10, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants