-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
namespace mxnet { | ||
namespace op { | ||
|
||
struct SwapAxis{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change struct SwapAxis to namespace SwapAxis {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually change to name space wilI need small captital letter
On Sun, Nov 8, 2015 at 10:11 PM Zhang Ming [email protected] wrote:
In src/operator/swapaxis-inl.h
#519 (comment):+#define MXNET_OPERATOR_SWAPAXIS_INL_H_
+
+#include <dmlc/logging.h>
+#include <dmlc/parameter.h>
+#include <mxnet/operator.h>
+#include
+#include
+#include
+#include
+#include
+#include "./operator_common.h"
+
+namespace mxnet {
+namespace op {
+
+struct SwapAxis{what do you mean?
—
Reply to this email directly or view it on GitHub
https://github.com/dmlc/mxnet/pull/519/files#r44243657.
Thanks! I have last few comments. I will merge it after these are fixed. |
everything is ok now! |
Failed ? |
There was a lint error, in the header file. You will need to change the namespace SwapAxis to small capital letter |
ok, I fix it now. |
One last thing, break https://travis-ci.org/dmlc/mxnet/jobs/90038655#L986 the line to two lines |
no lint problem now! |
add swapaxis operator into mxnet
Cool! Thanks for being patient, this is now merged |
😅 |
I want to join yours and contribute more. |
hello? |
I tend to say the Tensorflow is more like mshallow. @tqchen BTW, is the SwapAxis operator used to 'transpose' the tensor like the numpy do? @starimpact |
sure, it's just like the numpy's swapaxes function. |
OK, we explained that in http://mxnet.readthedocs.org/en/latest/faq.html#what-is-the-relation-to-tensorflow |
No description provided.