This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[WIP] scalar support for unary ndarray, ie. nd.sqrt(2), nd.log(3) #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not just float(1.414) |
piiswrong
reviewed
Feb 4, 2017
| @@ -97,6 +121,11 @@ def generic_ndarray_function(*args, **kwargs): | |||
| for i in args: | |||
| if isinstance(i, NDArrayBase): | |||
| ndargs.append(i) | |||
| elif num_args.value == 1: | |||
There was a problem hiding this comment.
This isn't valid. It breaks mx.nd.arange()
I think you should fix this by falling back on minpy side
There was a problem hiding this comment.
or at least check if this argument type is NDArray|Symbol
|
yes, I think it's easy to solve this on the MinPy side, but do you agree to make MXNet.NDArray to support such usage? @piiswrong |
|
We can make NDArray support scalar, but you need to check for argument type ("NDArray or Symbol") to make sure it's not meant to be a kwarg |
|
closed due to no recent activity. please feel free to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4844
BTW, it looks like MXNet.NDArray only accept array-like data, so
nd.sqrt(2)will returnarray([1.41421354])instead ofarray(1.41421354)