This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix image-classification import error with python3 #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajiedesign
changed the title
yajiedesign
force-pushed
the
master_imgclass
branch
from
1c58591
to
c099238
Compare
piiswrong
reviewed
Jan 16, 2017
| @@ -86,7 +86,7 @@ def validate(self, attrs): | |||
| sys.exit(1) | |||
| try: | |||
| #check if the network exists | |||
| importlib.import_module('symbol.'+ args[0]) | |||
| importlib.import_module('symbols.'+ args[0]) | |||
There was a problem hiding this comment.
because conflict with mx.symbol
in python3 can't loading.
piiswrong
reviewed
Jan 16, 2017
| @@ -12,13 +12,13 @@ def get_symbol(num_classes, **kwargs): | |||
| data=input_data, kernel=(11, 11), stride=(4, 4), num_filter=96) | |||
| relu1 = mx.symbol.Activation(data=conv1, act_type="relu") | |||
| pool1 = mx.symbol.Pooling( | |||
| data=relu1, pool_type="max", kernel=(3, 3), stride=(2,2)) | |||
| data=relu1, pool_type="max", kernel=(3, 3), stride=(2,2), pad=(1, 1)) | |||
There was a problem hiding this comment.
this breaks backward compatibility.
There was a problem hiding this comment.
yes.the pool1 no problem. no need for pad.
do other pool pad lead to compatibility issues?
yajiedesign
force-pushed
the
master_imgclass
branch
from
c155f98
to
0eb840a
Compare
fix alexnet and googlenet pooling pad error remove first pool pad. remove pad
yajiedesign
force-pushed
the
master_imgclass
branch
from
0eb840a
to
4c628ee
Compare
rravu3
pushed a commit
to rravu3/mxnet
that referenced
this pull request
Jan 21, 2017
* fix import error with python3 fix alexnet and googlenet pooling pad error remove first pool pad. remove pad * Update alexnet.py
|
alexnet and googlenet are wrongly switched #4826 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix import error with python3