This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Infershape fix #2750
Closed
Infershape fix #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [RFC] Embedding DTypes * [RFC] [DTypes] Embedding python test
�ý5O ���:q :q! �ý5q�kb�kb�kb:q
|
The break was intentional. The original behavior of pooling layer was strange and non standard. We should update all pretrained models instead of revert infershape |
|
Ok, then current pr should be good to handle type issue. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Infershape in pooling comparing unsigned type with zero. However the problems in #2718 and #2709 are not fixed. The stride was removed in the numerator in latest commit. I can revert it back to previous version, so some old network setup get working. But I need to know if we should do so and reasons for not to do it.
@antinucleon @sxjscience @tqchen