-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
breaking all previous models seems really bad... |
Only break Inception family. I have fixed symbols and pretrained model. |
does it affect vgg? |
I think vgg is ok |
@tqchen @piiswrong please check this. If it is ok we can merge this first because it fix travis. |
@@ -17,7 +17,7 @@ def DownsampleFactory(data, ch_3x3, mirror_attr): | |||
# conv 3x3 | |||
conv = ConvFactory(data=data, kernel=(3, 3), stride=(2, 2), num_filter=ch_3x3, pad=(1, 1), mirror_attr=mirror_attr) | |||
# pool | |||
pool = mx.symbol.Pooling(data=data, kernel=(3, 3), stride=(2, 2), pool_type='max', attr=mirror_attr) | |||
pool = mx.symbol.Pooling(data=data, kernel=(3, 3), stride=(2, 2), pad=(1, 1), pool_type='max', attr=mirror_attr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about inception v3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V3 is OK
what is the status on this PR? |
Will do pairtest with Torch today |
please let me know if it is ready to merg |
@tqchen looks like dmlc/any.h broke windows build |
will push a fix |
I am working on CUDNN tuning. Will be finished very soon. |
@piiswrong @tqchen It is done. There is a possible refactor, but I think we can refactor it after we fix deepmark |
@@ -11,6 +11,7 @@ | |||
namespace mxnet { | |||
namespace op { | |||
#if MXNET_USE_CUDNN == 1 | |||
// TODO(xxx): Refactor with Init CuDNN function, remove redandent code in initalization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this intentionally so that it would be easier to isolate this into it's own tune class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But many initialization code are exactly same, this part should be refactored.
@antinucleon I have updated dmlc-core so that any should be compatible with windows build |
any updates? |
Wait me 1 hour,
|
@tqchen If it is OK, merge it then I will update pretrained model |
oshape[2] = 1; | ||
oshape[3] = 1; | ||
} else { | ||
oshape[2] = 1 + (dshape[2] + 2 * param_.pad[0] - param_.kernel[0]) / param_.stride[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I got some problem when testing old code with new pooling interface as the datatype used here is unsigned int. Maybe we need some more fool proof stuff here. This issue can be fixed if I claim it as global_pool.
- given input shape of 6 and kernel size 7. it can exit with alert of "kernel size exceed input".
- given input shape of 6 and kernel size 8, you can sneak through this check with 4294967296(max value of unsigned int).
It still cant work well with inception-BN model. COULD anyone fix this? It really cause me headache... Thanks a lot! |
@Lorrainexun I have fixed the pretrained model symbol. It is because change of pooling shape. |
Hi,all. I compiled the latest mxnet with cudnn 5 and thus can use 3D conv. The vgg and alexnet in deepmark are ok. However, when I try to run c3d.py I met a problem: mxnet.base.MXNetError: Error in operator pooling4: [11:50:48] src/operator/./pooling-inl.h:232: Check failed: param_.kernel[0] < dshape[2] + 2 * param_.pad[ This can be seen whenever I want to collapse the last two frames into one in other C3D models. |
Important changes: