This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch, #19945 from master #20785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change env variable used to detect whether it's a release build or not. RELEASE_BUILD is already setup in the CD pipeline. * Refine how variable is compared to trigger release builds. * Check for 'true' exclusively, to prevent unwanted release builds. * Make sure we pass any environment variables on the build.py command line to the docker run command.
* Add wheel to installed pip packages on aarch64, so we can build the wheel in the CD pipeline. * Better support for aarch64 docker container cache. * Only import machine() function from platform module, as platform variable is already widely used. * Only build containers with aarch64 in name on aarch64. * Make all arch defaults to local machine type.
josephevans
requested review from
aaronmarkham,
marcoabreu and
szha
as code owners
December 20, 2021 18:12
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [miscellaneous, unix-cpu, windows-cpu, website, clang, unix-gpu, sanity, windows-gpu, centos-gpu, centos-cpu, edge] Note: |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Dec 20, 2021
…onnect timeout from 10 to 60sec, increase retry delay from 0 (setting duplicated) to 30, increase retry attempts to 5.
josephevans
changed the title
[v1.x] Backport #20782 and #20783 from v1.9.x branch
[v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch
Dec 21, 2021
mseth10
added
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Dec 21, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Dec 21, 2021
* fix website * fix header * fix index * remove locall test * fix main.scss Co-authored-by: Wei Chu <[email protected]>
josephevans
changed the title
[v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch
[v1.x] Backport #20782, #20783 and #20786 from v1.9.x branch, #19945 from master
Dec 21, 2021
mseth10
added
the
pr-awaiting-testing
PR is reviewed and waiting CI build and test
label
Dec 21, 2021
waytrue17
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
mseth10
added
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Dec 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport CD/CI fixes from v1.9.x and master branches into v1.x branch.