Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Master][CI][Bugfix] Clang-format-13 file needs to have right license header and install clang-format package. #20658

Merged
merged 4 commits into from
Oct 12, 2021
Merged

[Master][CI][Bugfix] Clang-format-13 file needs to have right license header and install clang-format package. #20658

merged 4 commits into from
Oct 12, 2021

Conversation

mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Oct 11, 2021 •
edited
Loading

Description

The problem statement: Clang-format file: the following file doesn't have a valid license header

2021-10-11T07:16:25.4235681Z �[31mERROR�[0m the following files don't have a valid license header:
2021-10-11T07:16:25.4236608Z tools/lint/git-clang-format-13
2021-10-11T07:16:25.5674018Z Post job cleanup.

A clang-format package needs to be installed.

"+" @barry-jin changes: #20660

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, centos-gpu, unix-gpu, website, edge, clang, centos-cpu, unix-cpu, windows-cpu, sanity, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Oct 11, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 11, 2021
@mozga-intel mozga-intel changed the title [Master][CI][Bugfix] Clang-format-13 file needs to have right license header. [Master][CI][Bugfix] Clang-format-13 file needs to have right license header and install clang-format package. Oct 11, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 11, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 11, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 12, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 12, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 12, 2021
@mozga-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 12, 2021
@barry-jin barry-jin mentioned this pull request Oct 12, 2021
Closed
6 tasks
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 12, 2021
@mozga-intel
Copy link
Contributor Author

@barry-jin, @szha Could you please review it?

barry-jin
barry-jin approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@barry-jin barry-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@szha szha merged commit 0d09770 into apache:master Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barry-jin barry-jin barry-jin approved these changes

@akarbown akarbown akarbown approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mozga-intel @mxnet-bot @akarbown @barry-jin @szha @mseth10