Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v2.0.0.beta0] License Fix #20627

Merged
merged 2 commits into from
Oct 4, 2021
Merged

[v2.0.0.beta0] License Fix #20627

merged 2 commits into from
Oct 4, 2021

Conversation

barry-jin
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, windows-gpu, centos-gpu, unix-cpu, edge, centos-cpu, clang, unix-gpu, website, miscellaneous, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 2, 2021
josephevans
josephevans approved these changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, miscellaneous, unix-cpu, website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, miscellaneous, website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 2, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 3, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 4, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 4, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 4, 2021
@barry-jin barry-jin merged commit 4b017f2 into apache:v2.0.0.beta0 Oct 4, 2021
@barry-jin barry-jin deleted the license-fix branch October 4, 2021 15:49
barry-jin added a commit to barry-jin/incubator-mxnet that referenced this pull request Oct 7, 2021
@barry-jin
[v2.0.0.beta0] License Fix (apache#20627)
e84450a 
* [v2.0.0.beta0] License Fix

* freeze array-api-test version
@barry-jin barry-jin mentioned this pull request Oct 7, 2021
Merged
6 tasks
barry-jin added a commit that referenced this pull request Oct 14, 2021
@barry-jin
[Master] Port #20627 (#20645)
b94fda7 
* [v2.0.0.beta0] License Fix (#20627)

* [v2.0.0.beta0] License Fix

* freeze array-api-test version

* Update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@josephevans josephevans josephevans approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barry-jin @mxnet-bot @szha @josephevans @mseth10