Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[API Standardization]Standardize MXNet NumPy Statistical & Linalg Functions #20592

Merged
merged 27 commits into from
Oct 14, 2021
Merged

[API Standardization]Standardize MXNet NumPy Statistical & Linalg Functions #20592

merged 27 commits into from
Oct 14, 2021

Conversation

NathanYyc
Copy link
Contributor

Description

Part of API standardization

  • add element-wise functions

  • add manipulation functions

  • change statistical functions

    • std: change keyword "ddof" to "correction"
    • var: change keyword "ddof" to "correction"

  • change linalg functions

    • add vecdot
    • eigvalsh: change keyword "UPLO" to "upper"
    • eigh: change keyword "UPLO" to "upper"

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @NathanYyc , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, windows-gpu, unix-gpu, edge, clang, centos-cpu, centos-gpu, miscellaneous, sanity, website, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@NathanYyc
Copy link
Contributor Author

@barry-jin

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 17, 2021
barry-jin
barry-jin suggested changes Sep 17, 2021
View reviewed changes
python/mxnet/numpy/linalg.py Outdated Show resolved Hide resolved
python/mxnet/numpy/linalg.py Outdated Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved
python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved
@barry-jin barry-jin mentioned this pull request Sep 17, 2021
Open
52 tasks
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Sep 22, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 22, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 24, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 24, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 11, 2021
@NathanYyc
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 11, 2021
barry-jin
barry-jin suggested changes Oct 11, 2021
View reviewed changes
python/mxnet/numpy/linalg.py Show resolved Hide resolved
python/mxnet/numpy/linalg.py Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 12, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 13, 2021
@NathanYyc
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@NathanYyc
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 13, 2021
barry-jin
barry-jin approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@barry-jin barry-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@barry-jin barry-jin merged commit ab6a3f9 into apache:master Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barry-jin barry-jin barry-jin approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NathanYyc @mxnet-bot @barry-jin @mseth10