Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix Windows-GPU build for monolithic arch dll #20466

Merged
merged 1 commit into from
Oct 17, 2021
Merged

[BUGFIX] Fix Windows-GPU build for monolithic arch dll #20466

merged 1 commit into from
Oct 17, 2021

Conversation

matteosal
Copy link
Contributor

When building on Windows + CUDA, the combination USE_SPLIT_ARCH_DLL=OFF/MXNET_FORCE_SHARED_CRT=OFF leads to a branch where an undefined variable arch is being used, wrongly copy/pasted from the branch USE_SPLIT_ARCH_DLL=ON a few lines above.

@mxnet-bot
Copy link

Hey @matteosal , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-cpu, edge, website, windows-gpu, clang, miscellaneous, unix-cpu, unix-gpu, centos-cpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu
Copy link
Contributor

leezu commented Jul 28, 2021

@mxnet-bot run ci [all]

1 similar comment
@matteosal
Copy link
Contributor Author

@mxnet-bot run ci [all]

@matteosal
Copy link
Contributor Author

@leezu it seems that the CI just doesn't start here, what's happening?

@leezu
Copy link
Contributor

leezu commented Oct 14, 2021

@mxnet-bot run ci [all]

@leezu
Copy link
Contributor

leezu commented Oct 14, 2021

@mxnet-bot run ci [centos-gpu, windows-cpu, edge, website, windows-gpu, clang, miscellaneous, unix-cpu, unix-gpu, centos-cpu, sanity]

@leezu
Copy link
Contributor

leezu commented Oct 14, 2021

@matteosal I notified the team who operates the infrastructure. The issue appears specific to your PR. In case the issue is related to the CI's inability to merge your branch into master, you could resolve it by rebase on master and force push. But that's just a guess. If this turns out to be the case, the bot should be updated to surface the error instead of silently failing.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 15, 2021
@matteosal
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 15, 2021
@matteosal
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 15, 2021
@matteosal
Copy link
Contributor Author

@leezu I have rebased and retriggered a couple of jobs, it worked

@leezu leezu merged commit 6bbe886 into apache:master Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matteosal @mxnet-bot @leezu @mseth10