Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Java2.0 proto #20461

Merged
merged 63 commits into from
Oct 5, 2021
Merged

Java2.0 proto #20461

merged 63 commits into from
Oct 5, 2021

Conversation

channel960608
Copy link

Description

A draft implement of java front-end for MXNet 2.0 refer to DeepJavaLibrary

Checklist

Essentials

  • [FEATHER] load MXNet binary library
  • [FEATHER] add required components of MXNet: Symbol, NDArray and CachedOP
  • [FEATHER] implement simple inference using the components above

Changes

none

Comments

none

cspchen added 18 commits June 28, 2021 21:28
ADD: first commit
3aa0a24
ADD: load local libraries
735320d
UPDATE: use header files of MXNet 2.0
67e2988
ADD: load binaries from environment variable, java properties or jar …
563bdcd 
…files.
ADD: add symbol loading and closing
5829a44 
add module integration
ADD: [WIP] Component MxNDArray
5250246
ADD: [WIP] Component MxNDArray
8a666f7
ADD: Component MxNDArray. Pass static compilation check
aba88ab
ADD: Component CachedOp
b1037ed
REMOVE: module api which is no use
edbf730
FIX: dependency missing
df2d0c7
ADD: [WIP] add test cases for NdArray and CachedOp
6c4e7d7
ADD: [WIP] add test cases for NdArray and CachedOp
b9b9021
Merge branch 'master' into jave2.0-proto
a458c54
ADD: implement of the forward function for MxSymbolblock
64b443d
ADD: implement of the forward function for MxSymbolblock
92e4814
ADD: Sample model downloader for MLP
f99f813
ADD: doc
8020d69
@mxnet-bot
Copy link

Hey @channel960608 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, clang, miscellaneous, sanity, unix-gpu, centos-gpu, website, windows-cpu, unix-cpu, windows-gpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Jul 20, 2021
@channel960608 channel960608 changed the title Jave2.0 proto [WIP] Jave2.0 proto Jul 20, 2021
@leezu
Copy link
Contributor

leezu commented Jul 20, 2021

java2.0 branch is currently 21 commits behind master. This PR would be easier to review if you can update the java2.0 branch to match master first, and only include new / original commits in this PR. Thank you!

@channel960608 channel960608 changed the title [WIP] Jave2.0 proto [WIP] Java2.0 proto Jul 20, 2021
@channel960608
Copy link
Author

java2.0 branch is currently 21 commits behind master. This PR would be easier to review if you can update the java2.0 branch to match master first, and only include new / original commits in this PR. Thank you!

That's right. I will contact @lanking520 to update java2.0 branch. Thanks.

@leezu
Copy link
Contributor

leezu commented Jul 20, 2021

Ok, thank you. I've updated the java2.0 branch just now

@lanking520
Copy link
Member

can you do

git submodule update --init --recursive

?

lanking520
lanking520 suggested changes Jul 21, 2021
View reviewed changes
java-package/integration/build.gradle Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 25, 2021
@lanking520
Copy link
Member

Is now a good time to review?

@channel960608
Copy link
Author

Is now a good time to review?

sure

lanking520
lanking520 reviewed Sep 27, 2021
View reviewed changes
src/initialize.cc Outdated Show resolved Hide resolved
lanking520
lanking520 approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 29, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 29, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 29, 2021
@channel960608
Copy link
Author

@mxnet-bot run ci [clang]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [clang]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 29, 2021
@lanking520 lanking520 merged commit 672a9fa into apache:java2.0 Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barry-jin barry-jin barry-jin left review comments

@lanking520 lanking520 lanking520 approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@leezu leezu Awaiting requested review from leezu leezu is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@lanking520 lanking520

Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@channel960608 @mxnet-bot @leezu @lanking520 @marcoabreu @barry-jin @mseth10