Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX][API] fix #20447 #20454

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[BUGFIX][API] fix #20447 #20454

wants to merge 13 commits into from

Conversation

barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Jul 17, 2021

Description

Fix #20447

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Add inplace : bool parameter to identify in-place operation in C++
  • Add test_array_api_standard.py for python array api standard related tests

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@barry-jin barry-jin requested a review from szha as a code owner July 17, 2021 00:33
@mxnet-bot
Copy link

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, website, windows-cpu, windows-gpu, edge, unix-cpu, centos-cpu, centos-gpu, clang, miscellaneous, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Jul 17, 2021
@barry-jin barry-jin changed the title [WIP][BUGFIX][API] fix #20477 [WIP][BUGFIX][API] fix #20447 Aug 12, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu, unix-gpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, unix-gpu, unix-cpu]

@barry-jin barry-jin changed the title [WIP][BUGFIX][API] fix #20447 [BUGFIX][API] fix #20447 Dec 14, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 14, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu, unix-gpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, unix-cpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2021
@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2.0] Type Infer Error for MXNet NumPy Array in-place Operation
3 participants