Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

issue#20343: assign input param delay_alloc_ to delay_alloc #20351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ooooona
Copy link

@ooooona ooooona commented Jun 15, 2021

Description

please refer to issu#20343

Comments

hotfix: assign input param delay_alloc_ to delay_alloc rather than 'true'

hotfix: assign  input param `delay_alloc_` to `delay_alloc` rather than 'true'
pls refer to [issu#20343](apache#20343)
@mxnet-bot
Copy link

Hey @ooooona , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, unix-cpu, centos-gpu, unix-gpu, website, sanity, windows-cpu, centos-cpu, clang, edge, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 15, 2021
@szha szha requested review from szha and wkcn June 18, 2021 14:57
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a bug.

If delay_alloc is set to be false in initialization, Storage::Get()->Alloc(&shandle); will not be called in the function this->CheckAndAlloc().

CheckAndAlloc() will set delay_alloc to be false after allocating the memory.

https://github.com/apache/incubator-mxnet/blob/b54b7f36c944b933f2aa94f224821548da5fcaf6/include/mxnet/ndarray.h#L1018-L1026

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants