This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] ONNX support for _split_v2 #20250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2021 18:38
|
Hey @waytrue17 , Thanks for submitting the PR
CI supported jobs: [clang, miscellaneous, unix-gpu, edge, centos-cpu, unix-cpu, centos-gpu, windows-cpu, website, windows-gpu, sanity] Note: |
mseth10
added
the
pr-awaiting-testing
Zha0q1
reviewed
May 6, 2021
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py
Outdated
Show resolved
Hide resolved
| @@ -1858,3 +1858,19 @@ def rand_check(out): | |||
| def rand_check_nd(out): | |||
| return rand_check(out.asnumpy()) | |||
| op_export_test('sample_multinomial', M, [x], tmp_path, mx_map=rand_check_nd, onnx_map=rand_check) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("dtype", ['float32', 'int32', 'int64']) | |||
There was a problem hiding this comment.
Is the customer use case covered by the unit tests?
There was a problem hiding this comment.
Customer has not shared their use case yet
python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py
Outdated
Show resolved
Hide resolved
mseth10
added
pr-work-in-progress
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ONNX support and unittest for _split_v2
Checklist
Essentials
Changes
Comments