Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Upate ps-lite to fix the zmq not found issue #20248

Merged
merged 1 commit into from
May 6, 2021

Conversation

TristonC
Copy link
Contributor

@TristonC TristonC commented May 5, 2021

Description

Update ps-lite for v1.x branch to include the fix for zmq not found issue.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Update the ps-lite to include PR 170

Comments

This is used to fix the issue of "3rdparty/ps-lite/src/./zmq_van.h:8:10: fatal error: zmq.h: No such file or directory".

@mxnet-bot
Copy link

Hey @TristonC , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, website, windows-gpu, sanity, miscellaneous, centos-gpu, clang, unix-cpu, edge, windows-cpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label May 5, 2021
@TristonC
Copy link
Contributor Author

TristonC commented May 5, 2021

@leezu Please help review.

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This backports #17732

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 6, 2021
@TristonC
Copy link
Contributor Author

TristonC commented May 6, 2021

@leezu Could you check the CI errors?

@leezu
Copy link
Contributor

leezu commented May 6, 2021

@mxnet-bot run ci [unix-gpu, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 6, 2021
@TristonC
Copy link
Contributor Author

TristonC commented May 6, 2021

@leezu What is hte one waiting for aproval workflow here?

@leezu
Copy link
Contributor

leezu commented May 6, 2021

It may be a recent Github Actions feature to make it harder to exploit security vulnerabilities in Github Action at scale

@leezu leezu merged commit 923b608 into apache:v1.x May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants