Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x][Bugfix] Fix take gradient #20166

Merged
merged 2 commits into from
Apr 16, 2021
Merged

[v1.x][Bugfix] Fix take gradient #20166

merged 2 commits into from
Apr 16, 2021

Conversation

waytrue17
Copy link
Contributor

Description

Fix #19817. Reset value of grad_in when axis != 0. The fix was tested by the script described in #19817

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-gpu, centos-cpu, edge, miscellaneous, windows-gpu, unix-gpu, unix-cpu, clang, windows-cpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Apr 15, 2021
@waytrue17
Copy link
Contributor Author

Can you please review @Zha0q1 @szha

@szha
Copy link
Member

szha commented Apr 15, 2021

Thanks @waytrue17. Could you add a test for the bug? Is this patch needed for master?

@waytrue17
Copy link
Contributor Author

Thanks @waytrue17. Could you add a test for the bug? Is this patch needed for master?

Test added. Master also needs this. I can port it after this pr merged

@waytrue17
Copy link
Contributor Author

@mxnet-bot run ci [centos-cpu]

@szha szha merged commit 79d3d48 into apache:v1.x Apr 16, 2021
@szha
Copy link
Member

szha commented Apr 16, 2021

@waytrue17 thanks for the fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants