Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BACKPORT] #19725, #19801 #19942

Merged
merged 2 commits into from
Feb 23, 2021
Merged

[BACKPORT] #19725, #19801 #19942

merged 2 commits into from
Feb 23, 2021

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Feb 22, 2021 •
edited
Loading

Backporting #19725, #19801 as a port of effort #19911

@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, windows-gpu, centos-gpu, website, miscellaneous, clang, edge, windows-cpu, centos-cpu, unix-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 22, 2021
@access2rohit
Copy link
Contributor Author

@josephevans please review

josephevans
josephevans reviewed Feb 22, 2021
View reviewed changes
tools/pip/doc/CU112_ADDITIONAL.md Outdated Show resolved Hide resolved
ci/docker/docker-compose.yml Outdated Show resolved Hide resolved
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 22, 2021
@access2rohit access2rohit changed the title [BACKPORT] #19725, #19726, #19764, #19801 [BACKPORT] #19725, #19726, #19801 Feb 22, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 22, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 23, 2021
@access2rohit access2rohit changed the title [BACKPORT] #19725, #19726, #19801 [BACKPORT] #19725, #19801 Feb 23, 2021
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 23, 2021
josephevans
josephevans approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@josephevans josephevans mentioned this pull request Feb 23, 2021
Closed
@access2rohit access2rohit mentioned this pull request Feb 23, 2021
Closed
13 tasks
@leezu leezu merged commit e1d1105 into apache:v1.x Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@access2rohit @mxnet-bot @josephevans @leezu @lanking520