Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Unskip Flaky test_gluon_data tests #19919

Merged
merged 2 commits into from
Feb 20, 2021
Merged

[v1.x] Unskip Flaky test_gluon_data tests #19919

merged 2 commits into from
Feb 20, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Feb 19, 2021 •
edited
Loading

#19924 this pr should fix the flaky tests, thus unskipping them

@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, windows-gpu, windows-cpu, website, centos-cpu, clang, unix-cpu, sanity, centos-gpu, edge, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 19, 2021
josephevans
josephevans approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 19, 2021
@Zha0q1 Zha0q1 changed the title [v1.x] Skip Flaky test_gluon_data.test_list_dataset [v1.x] Unskip Flaky test_gluon_data tests Feb 19, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 19, 2021
@Zha0q1 Zha0q1 merged commit 141f919 into apache:v1.x Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zha0q1 @mxnet-bot @josephevans @lanking520