This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] Tool to help update/restore onnx support #19876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Zha0q1 , Thanks for submitting the PR
CI supported jobs: [windows-cpu, website, clang, centos-cpu, windows-gpu, centos-gpu, edge, unix-gpu, unix-cpu, miscellaneous, sanity] Note: |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
josephevans
reviewed
Feb 15, 2021
| # Detect MXNet | ||
| print('Detected MXNet version: %s' % mxnet.__version__) | ||
| mx_path = os.path.abspath(mxnet.__file__) | ||
| mx_path = mx_path[:mx_path.rfind('/')] |
There was a problem hiding this comment.
You might want to use os.path.join(mx_path, "..", "contrib", "onnx"), so this will work in windows as well.
| logging.error('ONNX backup path not found. %s does not exist' % backup_path) | ||
|
|
||
| # Restore backup | ||
| os.chdir(onnx_path) |
There was a problem hiding this comment.
For this to work on windows, could you just check if the backup path exists and move it back then? The find/cp/rm commands won't work under windows.
lanking520
added
pr-work-in-progress
mseth10
added
pr-awaiting-testing
mseth10
added
pr-work-in-progress
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we frequently improve our ONNX support, users might want to get timely access to the latest changes. However, MXNet releases might not happen as frequent as the users would want and they might have other compatibility concerns to update the entire mxnet module. To help with this, this pr adds a simple tool to update(replace) and restore the
mxnet/contrib/onnxfolder to the latest version on github. For example, a user that has mxnet 1.7 installed can use this script to get the latest onnx support without updating mxnet to a later version. This script helps make our onnx support more accessible and users can report bugs back and expect them fixed more easily.The script will automatically find the currently installed mxnet. The original files will be backuped to
mxnet/contrib/onnx/backup.--branchoption controls which mxnet branch to checkout and if--restoreoption is specified then files inbackupwill be restored.To update to changes in v1.x
To update to changes in a specific branch
To restore the original files