Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Move majority of ONNX model tests to nightly, only test a few models in PR pipeline #19848

Merged
merged 15 commits into from
Feb 12, 2021

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Feb 5, 2021

Description

This PR moves the running of all ONNX export model end-to-end tests to the nightly build pipeline. There are just too many models to test for the normal CI pipeline that gets triggered for each PR. This tests one (or a few) models of each category. We can still manually run the tests and nightly pipeline will also run them.

Added onnx end-to-end tests for all currently supported models.

Also replace deprecated ConstantFill operator with Identity operator.

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, sanity, centos-cpu, miscellaneous, website, windows-cpu, unix-gpu, edge, unix-cpu, windows-gpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 5, 2021
@josephevans josephevans changed the title [v1.x] Test moving onnx CI stage to unix-gpu pipeline [v1.x] Update ONNX unit tests to add all supported models Feb 5, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 5, 2021
@josephevans josephevans force-pushed the onnx_fixes_round14_v1.x branch 2 times, most recently from 3218ebb to c8ee99a Compare February 5, 2021 21:50
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 6, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 9, 2021
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 9, 2021
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 10, 2021
@josephevans josephevans changed the title [v1.x] Split ONNX test stage into 5 different stages [v1.x] Move majority of ONNX model tests to nightly, only test a few models in PR pipeline Feb 11, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 11, 2021
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 11, 2021
Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 12, 2021
@ChaiBapchya ChaiBapchya merged commit 80ccb4b into apache:v1.x Feb 12, 2021
@josephevans josephevans deleted the onnx_fixes_round14_v1.x branch February 12, 2021 03:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants