Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix numpy pad operator #19787

Merged
merged 3 commits into from
Jan 29, 2021
Merged

[BUGFIX] Fix numpy pad operator #19787

merged 3 commits into from
Jan 29, 2021

Conversation

barry-jin
Copy link
Contributor

Description

Fix issue #19777

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Broadcast pad_width to (ndim, 2).

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, centos-gpu, centos-cpu, windows-cpu, sanity, unix-cpu, miscellaneous, website, edge, windows-gpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 25, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 25, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [miscellaneous, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, miscellaneous]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 26, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [miscellaneous, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous, windows-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 27, 2021
@szha
Copy link
Member

szha commented Jan 28, 2021

@josephevans any idea about the docker build failure in the misc pipeline?

@leezu leezu mentioned this pull request Jan 28, 2021
@leezu
Copy link
Contributor

leezu commented Jan 28, 2021

It's a legacy container build and I don't think anyone is maintaining it. It's failing now because Ubuntu 16.04 is no longer supported and it is based on 16.04. I'm not even sure it's still used, so I suggest to delete it to unblock the current PR #19801

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 28, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 28, 2021
@szha szha merged commit 3122423 into apache:master Jan 29, 2021
@szha
Copy link
Member

szha commented Jan 29, 2021

@barry-jin thanks for the fix!

@barry-jin barry-jin deleted the fix-np-pad branch March 31, 2021 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants