Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Migrate to use ECR as docker cache instead of dockerhub #19654

Merged
merged 12 commits into from
Feb 11, 2021
Merged

[v1.x] Migrate to use ECR as docker cache instead of dockerhub #19654

merged 12 commits into from
Feb 11, 2021

Commits on Feb 9, 2021

  1. Change the tag used for our docker containers so we can use a single … 

    …ECR repository, but use the platform and a hash of the dockerfile in the tag name so we can cache across branches. Also push newly built containers up to ECR repo so future CI runs will not have to build entire container.
    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d0ca0a1 View commit details
    Browse the repository at this point in the history

  2. Use new env variable for new ECR registry in order to test.

    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a2d58de View commit details
    Browse the repository at this point in the history

  3. Fix typo.

    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    bb1436d View commit details
    Browse the repository at this point in the history

  4. Fix variable name and make sure we login to ECR before attempting to … 

    …pull image.
    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a10381b View commit details
    Browse the repository at this point in the history

  5. Fix variable.

    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a4df078 View commit details
    Browse the repository at this point in the history

  6. Specify region based on environment variable.

    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    762dc55 View commit details
    Browse the repository at this point in the history

  7. Only push image to docker cache when DOCKER_ECR_CACHE is defined.

    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    235390a View commit details
    Browse the repository at this point in the history

  8. Add all copied files to hash context to make sure it's unique.

    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d1e8cae View commit details
    Browse the repository at this point in the history

  9. Move ECR logic to docker_cache.py, don't push containers in normal pi… 

    …peline - only push in restricted docker cache pipeline.
    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    2e58613 View commit details
    Browse the repository at this point in the history

  10. Remove invalid keyword arg docker_binary.

    Joe Evans committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    624223b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Merge remote-tracking branch 'upstream/v1.x' into docker_cache_v1.x

    Joe Evans committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    ab54767 View commit details
    Browse the repository at this point in the history

  2. Remove unused function.

    Joe Evans committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    70bb17a View commit details
    Browse the repository at this point in the history