This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @rondogency , Thanks for submitting the PR
CI supported jobs: [centos-cpu, unix-cpu, website, centos-gpu, edge, miscellaneous, clang, unix-gpu, windows-cpu, sanity, windows-gpu] Note: |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Nov 30, 2020
szha
approved these changes
Nov 30, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Dec 1, 2020
applied the same changes, seeing the same build failures here https://github.com/apache/incubator-mxnet/pull/19174a |
@mxnet-bot run ci [unix-cpu, website] |
Jenkins CI successfully triggered : [unix-cpu, website] |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Dec 1, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Dec 2, 2020
samskalicky
added a commit
to samskalicky/incubator-mxnet
that referenced
this pull request
Dec 3, 2020
6 tasks
samskalicky
added a commit
that referenced
this pull request
Dec 4, 2020
* initial commit * added warning message * added destroy function to call delete in custom library * try removing six per #19604 * fixed lint * fixed readability
samskalicky
added a commit
to samskalicky/incubator-mxnet
that referenced
this pull request
Dec 4, 2020
* initial commit * added warning message * added destroy function to call delete in custom library * try removing six per apache#19604 * fixed lint * fixed readability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix lint issue in #19603 on master (as @leezu mentioned it also affect mater)
Checklist
Essentials
Changes
Comments