Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Backport #19530 #19532

Merged
merged 1 commit into from
Nov 14, 2020
Merged

[v1.x] Backport #19530 #19532

merged 1 commit into from
Nov 14, 2020

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Nov 14, 2020 •
edited
Loading

Description

Backport #19530 - Changes to make builds work properly on Windows with Cuda 11.0.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Don't use namespace for pow() function, since it is built into cuda m…
cf25c11 
…ath library, and cast the second argument so it will find an acceptable form.

Remove thrust library override and use default from cuda 11.0.

Fix lint.
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, centos-cpu, unix-cpu, centos-gpu, clang, windows-cpu, edge, miscellaneous, unix-gpu, windows-gpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Nov 14, 2020
@samskalicky samskalicky merged commit 1f15d98 into apache:v1.x Nov 14, 2020
josephevans added a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
@josephevans
Don't use namespace for pow() function, since it is built into cuda m…
2b9682d 
…ath library, and cast the second argument so it will find an acceptable form. (apache#19532)

Remove thrust library override and use default from cuda 11.0.

Fix lint.

Co-authored-by: Joe Evans <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephevans @mxnet-bot @samskalicky @lanking520