Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix to quantization dshape bug #19501

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

grygielski
Copy link
Contributor

Description

This PR fixes #19477

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Moved data_shape=dshape assignment inside if calib_data is not None: branch

Comments

@grygielski grygielski requested a review from szha as a code owner November 9, 2020 12:03
@mxnet-bot
Copy link

Hey @grygielski , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, clang, centos-gpu, windows-cpu, sanity, edge, unix-gpu, unix-cpu, windows-gpu, website, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@grygielski
Copy link
Contributor Author

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 9, 2020
@anko-intel
Copy link
Contributor

LGTM

@grygielski
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 9, 2020
@grygielski
Copy link
Contributor Author

@szha

@szha szha merged commit f995e51 into apache:v1.x Nov 10, 2020
@szha
Copy link
Member

szha commented Nov 10, 2020

@grygielski thanks for the fix!

josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants