Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add SiLU #19497

Merged
merged 6 commits into from
Nov 9, 2020
Merged

Add SiLU #19497

merged 6 commits into from
Nov 9, 2020

Conversation

TFUsers
Copy link
Contributor

@TFUsers TFUsers commented Nov 9, 2020

The swish was originally coined the "SiLU" in https://arxiv.org/pdf/1606.08415.pdf long before the swish paper. Renaming other peoples' exact same ideas is unacceptable and mxnet's naming convention implicitly erases other peoples' research. This request inspired by a discussion and a recent tensorflow issue, but this problem has been brought up every few months for the past few years. In light of recent efforts to make the ML community more equitable and fair, this is a no-brainer and long overdue.

The SiLU has been added to pytorch 1.7, jax, tensorflow, and huggingface. This commit adds the silu as an activation function to mxnet.

@mxnet-bot
Copy link

Hey @TFUsers , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, unix-gpu, miscellaneous, centos-gpu, windows-cpu, sanity, website, clang, unix-cpu, windows-gpu, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 9, 2020
@szha
Copy link
Member

szha commented Nov 9, 2020

Thanks for bringing this up and making the correction.

@szha szha merged commit d4a5f2d into apache:master Nov 9, 2020
vidyaravipati pushed a commit to vidyaravipati/incubator-mxnet that referenced this pull request Nov 11, 2020
* add silu activation

* Update activations.md

* add activation images

* update activation docs

* add silu test

* add silu test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants