Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Mark test_random_gray as flaky #19493

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Mark test_random_gray as flaky #19493

merged 2 commits into from
Nov 8, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Nov 7, 2020 •
edited
Loading 

[2020-11-06T03:30:35.465Z]         for _ in range(iteration):
[2020-11-06T03:30:35.465Z]             out = transform(img)
[2020-11-06T03:30:35.465Z]             if out[0][0][0].asnumpy() != pixel:
[2020-11-06T03:30:35.465Z]                 num_apply += 1
[2020-11-06T03:30:35.465Z] >       assert_almost_equal(num_apply/float(iteration), 0.5, 0.1)
[...]
[2020-11-06T03:30:35.466Z] >       raise AssertionError(msg)
[2020-11-06T03:30:35.466Z] E       AssertionError: 
[2020-11-06T03:30:35.466Z] E       Items are not equal:
[2020-11-06T03:30:35.466Z] E       Error 1.100000 exceeds tolerance rtol=1.000000e-01, atol=1.000000e-20.
[2020-11-06T03:30:35.466Z] E       
[2020-11-06T03:30:35.466Z] E        ACTUAL: 0.445
[2020-11-06T03:30:35.466Z] E        DESIRED: 0.5

Fixes #19232
(track in source code instead of issue)

@leezu
Mark test_random_gray as flaky
7402191 
[2020-11-06T03:30:35.465Z]         for _ in range(iteration):
[2020-11-06T03:30:35.465Z]             out = transform(img)
[2020-11-06T03:30:35.465Z]             if out[0][0][0].asnumpy() != pixel:
[2020-11-06T03:30:35.465Z]                 num_apply += 1
[2020-11-06T03:30:35.465Z] >       assert_almost_equal(num_apply/float(iteration), 0.5, 0.1)
[...]
[2020-11-06T03:30:35.466Z] >       raise AssertionError(msg)
[2020-11-06T03:30:35.466Z] E       AssertionError: 
[2020-11-06T03:30:35.466Z] E       Items are not equal:
[2020-11-06T03:30:35.466Z] E       Error 1.100000 exceeds tolerance rtol=1.000000e-01, atol=1.000000e-20.
[2020-11-06T03:30:35.466Z] E       
[2020-11-06T03:30:35.466Z] E        ACTUAL: 0.445
[2020-11-06T03:30:35.466Z] E        DESIRED: 0.5
@leezu
Update test_numpy_gluon_data_vision.py
5d38751
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, windows-cpu, unix-gpu, website, unix-cpu, windows-gpu, edge, sanity, clang, miscellaneous, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 7, 2020
@leezu
Copy link
Contributor Author

leezu commented Nov 7, 2020

@mxnet-bot run ci [unix-gpu]

#10988

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 7, 2020
@leezu leezu merged commit abce30a into master Nov 8, 2020
@leezu leezu deleted the leezu-patch-5 branch November 8, 2020 00:05
vidyaravipati pushed a commit to vidyaravipati/incubator-mxnet that referenced this pull request Nov 11, 2020
@leezu
Mark test_random_gray as flaky (apache#19493)
5607b4c 
[2020-11-06T03:30:35.465Z]         for _ in range(iteration):
[2020-11-06T03:30:35.465Z]             out = transform(img)
[2020-11-06T03:30:35.465Z]             if out[0][0][0].asnumpy() != pixel:
[2020-11-06T03:30:35.465Z]                 num_apply += 1
[2020-11-06T03:30:35.465Z] >       assert_almost_equal(num_apply/float(iteration), 0.5, 0.1)
[...]
[2020-11-06T03:30:35.466Z] >       raise AssertionError(msg)
[2020-11-06T03:30:35.466Z] E       AssertionError: 
[2020-11-06T03:30:35.466Z] E       Items are not equal:
[2020-11-06T03:30:35.466Z] E       Error 1.100000 exceeds tolerance rtol=1.000000e-01, atol=1.000000e-20.
[2020-11-06T03:30:35.466Z] E       
[2020-11-06T03:30:35.466Z] E        ACTUAL: 0.445
[2020-11-06T03:30:35.466Z] E        DESIRED: 0.5

In other runs

[2020-11-07T05:30:27.511Z] >       raise AssertionError(msg)
[2020-11-07T05:30:27.511Z] E       AssertionError: 
[2020-11-07T05:30:27.511Z] E       Items are not equal:
[2020-11-07T05:30:27.511Z] E       Error 1.140000 exceeds tolerance rtol=1.000000e-01, atol=1.000000e-20.
[2020-11-07T05:30:27.511Z] E       
[2020-11-07T05:30:27.511Z] E        ACTUAL: 0.557
[2020-11-07T05:30:27.511Z] E        DESIRED: 0.5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_numpy_gluon_data_vision.py::test_random_gray
3 participants
@leezu @mxnet-bot @lanking520