Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Extension bug fixes #19469

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Extension bug fixes #19469

merged 4 commits into from
Nov 9, 2020

Conversation

samskalicky
Copy link
Contributor

Description

Bug fixes for extensions:

  • fixes segfault when args/aux are missing for graph pass & partitioning flows
  • fixes issue accepting mx.sym.var as inputs to optimize_for in gluon

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-cpu, clang, sanity, unix-gpu, centos-cpu, unix-cpu, edge, website, windows-gpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 4, 2020
@sxjscience
Copy link
Member

Are there any test cases?

@samskalicky
Copy link
Contributor Author

Are there any test cases?

Thanks @sxjscience for the reminder, I added a test case that covers both fixes.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Nov 4, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 5, 2020
Copy link
Contributor

@Kh4L Kh4L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes!

Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samskalicky samskalicky added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Nov 7, 2020
@samskalicky samskalicky merged commit 564c6d3 into apache:master Nov 9, 2020
samskalicky added a commit to samskalicky/incubator-mxnet that referenced this pull request Nov 9, 2020
* initial commit

* syntax fix

* spacing

* added test case
samskalicky added a commit to samskalicky/incubator-mxnet that referenced this pull request Nov 9, 2020
* initial commit

* syntax fix

* spacing

* added test case
vidyaravipati pushed a commit to vidyaravipati/incubator-mxnet that referenced this pull request Nov 11, 2020
* initial commit

* syntax fix

* spacing

* added test case
samskalicky added a commit that referenced this pull request Nov 13, 2020
* Extension bug fixes (#19469)

* initial commit

* syntax fix

* spacing

* added test case

* fixed indentation

* pinned h5py to <3

* fixed h5py
samskalicky added a commit that referenced this pull request Nov 13, 2020
* Extension bug fixes (#19469)

* initial commit

* syntax fix

* spacing

* added test case

* fixed indentation

* h5py version pinned to <3
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
)

* Extension bug fixes (apache#19469)

* initial commit

* syntax fix

* spacing

* added test case

* fixed indentation

* h5py version pinned to <3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants