This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x][BUGFIX]Fix MKLDNN BatchNorm with even number of channels (#19150) #19299 #19425 #19445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @akarbown , Thanks for submitting the PR
CI supported jobs: [windows-cpu, unix-gpu, edge, miscellaneous, website, unix-cpu, centos-cpu, sanity, clang, windows-gpu, centos-gpu] Note: |
akarbown
changed the title
lanking520
added
pr-awaiting-testing
Even number of channels results in data reordering before batch norm operation. Therefore, if BatchNorm data array is view of another array and the data is stored in MKLDNN format, the data needs to be converted to the default format.
akarbown
force-pushed
the
v1.x_batchnorm_is-view
branch
from
660bb24
to
2c11470
Compare
lanking520
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-gpu] |
|
Jenkins CI successfully triggered : [unix-gpu] |
lanking520
added
pr-awaiting-testing
Merged
6 tasks
lanking520
added
pr-awaiting-review
samskalicky
approved these changes
Oct 29, 2020
josephevans
pushed a commit
to josephevans/mxnet
that referenced
this pull request
Dec 8, 2020
…he#19150) apache#19299 apache#19425 (apache#19445) * Fix MKLDNN BatchNorm with even number of channels (apache#19150) Even number of channels results in data reordering before batch norm operation. Therefore, if BatchNorm data array is view of another array and the data is stored in MKLDNN format, the data needs to be converted to the default format. * Add or updated test to verify Batchnorm odd & even number of channels * Fix for Batchnorm odd & even chnls number context
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's the change (#19299) ported form mxnet 1.7.
Checklist
Essentials