Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

updating License for dlpack for v1.8 release #19433

Closed
wants to merge 1 commit into from

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Oct 27, 2020

Description

update dlpack's LICENSE #19427

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)

@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, windows-cpu, windows-gpu, centos-cpu, unix-cpu, centos-gpu, edge, miscellaneous, website, unix-gpu, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@access2rohit
Copy link
Contributor Author

@samskalicky @leezu Can you review ?

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Oct 27, 2020
@sandeep-krishnamurthy
Copy link
Contributor

Thank you.

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 28, 2020
@leezu
Copy link
Contributor

leezu commented Oct 28, 2020

There is no need to update the copyright notice. TVM doesn't include copyright notice (https://github.com/apache/incubator-tvm/blob/39cd612cdbf9a2443b5561b90b4b4a55996274f1/LICENSE#L203-L240) and it's not mentioned in the https://infra.apache.org/licensing-howto.html

@access2rohit
Copy link
Contributor Author

There is no need to update the copyright notice. TVM doesn't include copyright notice (https://github.com/apache/incubator-tvm/blob/39cd612cdbf9a2443b5561b90b4b4a55996274f1/LICENSE#L203-L240) and it's not mentioned in the https://infra.apache.org/licensing-howto.html

Its not for TVM it is for dlpack which is MXNet's direct dependecy. I made this PR to be consistent with what already exists in the MXNet's LICENSE file

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 29, 2020
@leezu
Copy link
Contributor

leezu commented Oct 29, 2020

It's great to be consistent with the existing MXNet License file but my point is that such consistent inclusion will be very hard to keep updated at every release and isn't needed according to the ASF licensing howto and TVM's practice: The howto states "In LICENSE, add a pointer to the dependency's license within the distribution and a short note summarizing its licensing" and does not require the inclusion of copyright statements.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 29, 2020
@josephevans
Copy link
Contributor

This change is already included in #19440, you can close this PR. Thanks @access2rohit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants