This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
External Operators 2 #19431
Merged
External Operators 2 #19431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samskalicky
requested review from
aaronmarkham,
leezu and
szha
as code owners
|
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [windows-cpu, clang, unix-cpu, sanity, edge, website, centos-cpu, unix-gpu, centos-gpu, miscellaneous, windows-gpu] Note: |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
wkcn
reviewed
Oct 30, 2020
wkcn
reviewed
Oct 30, 2020
lanking520
added
pr-awaiting-testing
wkcn
approved these changes
Oct 31, 2020
lanking520
added
pr-awaiting-merge
lanking520
added
pr-awaiting-testing
lanking520
added
pr-work-in-progress
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-review
lanking520
added
pr-awaiting-testing
samskalicky
added
pr-awaiting-merge
lanking520
added
pr-awaiting-testing
leezu
approved these changes
Nov 13, 2020
lanking520
added
pr-awaiting-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-on PR after the initial investigation in #18904 to support loading libraries containing MXNet backend components (particularly operators). Since #19241, the version script was removed and now Linux builds of
libmxnet.soexpose all MXNet symbols. This opens the door for dynamically loading libraries that depend onlibmxnet.so.This PR adds a build option
BUILD_EXTENSIONto the CMakeLists.txt file to give a path to the extension directory to build. This enables the existing MXNet build infrastructure to provide all includes directories automatically which simplifies building extensions.An example is also added in
examples/extensions/lib_external_opsthat builds an operator that is equivalent to a built-in/backend operator into a shared object and uses the existingmx.library.loadAPI to load that library at runtime.Caveots
Windows is not supported since by default all symbols are hidden in
mxnet.dllso dynamically loading libraries will not work. Similarly with Mac, the version script does not expose the necessary symbols at this time. These other platforms can be considered in the future based on user request & community motivation.