Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Fix CD builds - error in docker command. #19411

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Oct 22, 2020

Description

Remove extra --build-arg causing docker command to fail.

Errors with:

15:53:16 docker build -t mxnet/python:nightly_cpu_py3 --build-arg --build-arg BASE_IMAGE=ubuntu:16.04 --build-arg MXNET_COMMIT_ID=xxx -f cd/python/docker/Dockerfile ./wheel_build
15:53:16 "docker build" requires exactly 1 argument.
15:53:16 See 'docker build --help'.

This may not of been an issue, but we recently updated docker versions and this command is failiing.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, edge, windows-cpu, centos-gpu, centos-cpu, sanity, website, windows-gpu, clang, unix-cpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Oct 22, 2020
@josephevans josephevans changed the title Fix CD builds - error in docker command. [v1.x] Fix CD builds - error in docker command. Oct 22, 2020
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 23, 2020
@mseth10 mseth10 merged commit 9222fa1 into apache:v1.x Oct 23, 2020
josephevans added a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants