Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy histogram large tensor fix #19392

Merged
merged 4 commits into from
Oct 22, 2020
Merged

Numpy histogram large tensor fix #19392

merged 4 commits into from
Oct 22, 2020

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Oct 20, 2020

this pr fixes numpy histogram against large tensors

local run:

ubuntu@ip-172-31-38-169:~/workspace$ pytest tests/nightly/test_np_large_array.py::test_histogram
=================================================== test session starts ====================================================
platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
rootdir: /home/ubuntu/workspace, inifile: pytest.ini
plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
collected 1 item                                                                                                           

tests/nightly/test_np_large_array.py .                                                                               [100%]

===================================================== warnings summary =====================================================
tests/nightly/test_np_large_array.py:92
  /home/ubuntu/workspace/tests/nightly/test_np_large_array.py:92: DeprecationWarning: invalid escape sequence \ 
    '''

tests/nightly/test_np_large_array.py:1323
  /home/ubuntu/workspace/tests/nightly/test_np_large_array.py:1323: DeprecationWarning: invalid escape sequence \ 
    '''

-- Docs: https://docs.pytest.org/en/latest/warnings.html
============================================== 1 passed, 2 warnings in 23.46s ====================================

@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, windows-gpu, unix-cpu, centos-cpu, centos-gpu, sanity, windows-cpu, edge, unix-gpu, miscellaneous, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 21, 2020
Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leezu leezu merged commit 3f833e1 into apache:master Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants