This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[1.x] Update MXNet-TRT docs with the new optimize_for API #19385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Kh4L , Thanks for submitting the PR
CI supported jobs: [sanity, windows-gpu, unix-cpu, clang, centos-gpu, windows-cpu, website, unix-gpu, miscellaneous, centos-cpu, edge] Note: |
lanking520
added
pr-awaiting-testing
samskalicky
reviewed
Oct 21, 2020
docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
Outdated
Show resolved
Hide resolved
samskalicky
reviewed
Oct 21, 2020
docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
Outdated
Show resolved
Hide resolved
samskalicky
reviewed
Oct 21, 2020
docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
Outdated
Show resolved
Hide resolved
samskalicky
reviewed
Oct 21, 2020
docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
Outdated
Show resolved
Hide resolved
samskalicky
reviewed
Oct 21, 2020
docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
Outdated
Show resolved
Hide resolved
samskalicky
reviewed
Oct 21, 2020
docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
Show resolved
Hide resolved
samskalicky
reviewed
Oct 21, 2020
docs/python_docs/python/tutorials/performance/backend/tensorrt/tensorrt.md
Outdated
Show resolved
Hide resolved
lanking520
added
pr-awaiting-testing
Kh4L
changed the title
lanking520
added
pr-work-in-progress
samskalicky
reviewed
Oct 21, 2020
|
|
||
| We can give a simple speed up by turning on TensorRT FP16. This optimization comes almost as a freebie and doesn't need any other use effort than adding the optimize_for parameter precision. | ||
|
|
||
| ``` |
samskalicky
approved these changes
Oct 21, 2020
Signed-off-by: Serge Panev <[email protected]>
lanking520
added
pr-awaiting-testing
|
Just a reminder, we're waiting for an update to the installation instructions specific to building with TRT before merging. |
|
@samskalicky I am still waiting for updates from Wei, who is still trying to build it. I would suggest to merge this PR and I will make another one with the build instructions |
| # Warmup | ||
| for i in range(0, 1000): | ||
| out = model(x) | ||
| out[0].wait_to_read() |
There was a problem hiding this comment.
I'd be tempted to use mx.nd.waitall() for consistency with the samples above.
|
Thanks for the update on this Serge. Looks good to me. Small nit with code samples, but let's call it non-blocking. |
KellenSunderland
approved these changes
Oct 23, 2020
josephevans
pushed a commit
to josephevans/mxnet
that referenced
this pull request
Dec 8, 2020
Signed-off-by: Serge Panev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update MXNet-TRT docs with the new optimize_for API.
Also update the numbers, run on a V100 system.