Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.7.x] Cherry-pick "Fix SoftReLU fused operator numerical stability (#17849)" #19370

Merged
merged 1 commit into from
Oct 23, 2020
Merged

[v1.7.x] Cherry-pick "Fix SoftReLU fused operator numerical stability (#17849)" #19370

merged 1 commit into from
Oct 23, 2020

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Oct 17, 2020

  • fix numerically unstable fused softrelu op

  • implement test for softrelu numerical stability

@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, windows-cpu, unix-gpu, website, miscellaneous, unix-cpu, sanity, centos-gpu, edge, clang, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 17, 2020
@mseth10
Copy link
Contributor Author

mseth10 commented Oct 18, 2020

@mxnet-bot run ci [all]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 18, 2020
@RuRo @mseth10
Fix SoftReLU fused operator numerical stability (apache#17849)
dc4b22e 
* fix numerically unstable fused softrelu op

* implement test for softrelu numerical stability
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 23, 2020
@samskalicky samskalicky merged commit df7ef6c into apache:v1.7.x Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samskalicky samskalicky samskalicky approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mseth10 @mxnet-bot @samskalicky @lanking520 @RuRo