Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Backporting #19016 #19069

Merged
merged 8 commits into from
Sep 3, 2020
Merged

[1.x] Backporting #19016 #19069

merged 8 commits into from
Sep 3, 2020

Conversation

samskalicky
Copy link
Contributor

Description

Partially backporting #19016:

  • Refactors lib_api.h by moving the function definitions into lib_api.cc to simplify building extensions
  • Updates all the examples in example/extensions to use the new lib_api.cc build flow and updates version numbers in examples to 1.8

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, windows-cpu, centos-gpu, windows-gpu, website, centos-cpu, unix-cpu, miscellaneous, unix-gpu, sanity, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

Comment on lines +23 to +29
* \brief APIs to interact with libraries
* This API specifies function prototypes to
* register custom ops, partitioner, and passes
* for library authors
* See example/extension/lib_custom_op/README.md
* See example/extension/lib_subgraph/README.md
* See example/extension/lib_pass/README.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samskalicky samskalicky changed the title [WIP] Backporting #19016 [1.x] Backporting #19016 Sep 3, 2020
@samskalicky samskalicky added the v1.x Targeting v1.x branch label Sep 3, 2020
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samskalicky samskalicky merged commit b5e9c99 into apache:v1.x Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v1.x Targeting v1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants