This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[POC] Statically link to openblas #19068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Zha0q1 , Thanks for submitting the PR
CI supported jobs: [unix-gpu, website, sanity, centos-cpu, unix-cpu, windows-gpu, edge, miscellaneous, windows-cpu, clang, centos-gpu] Note: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC for statically linking to openblas and hiding blas/lapack symbols to avoid the name clashing issue as discussed here: #18855. This is meant as a reference rather for merging
For static build (using incubator-mxnet/tools/staticbuild/build.sh), we have #18872 to hide all the unwanted symbols, but this might be an overkill. In this pr, I listed explicitly what blas/lapack symbols to hide in the version script (linux only).
To friends at intel: I am linking to openblas in this poc, but I think we would need something very similar with mkl: 1. static link, 2. symbol stripping.