Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update symbol visibility control #19057

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update symbol visibility control #19057

wants to merge 2 commits into from

Commits on Sep 1, 2020

  1. Update symbol visibility control 

    Prior to this commit, linker version scripts were used to control the set of
visible symbols. These scripts included C++ Symbols, that do not have a stable
ABI and should not have been exported. Instead, we annotate the visiblity in the
source code as per the best practice.

Refer to "Deep CMake For Library Authors" CppCon 2019 talk by Craig Scott for
details on the cmake settings.
    @leezu
    leezu committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    4af8ff6 View commit details
    Browse the repository at this point in the history

  2. Remove MXNET_DLL macro in mxnet/ir and mxnet/runtime C++ interface

    @leezu
    leezu committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    6f47401 View commit details
    Browse the repository at this point in the history