Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Call the function Stop when custom op released #19051

Closed
wants to merge 1 commit into from

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Aug 31, 2020

Description

Hi there,
As title, it may fix #18789

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @wkcn , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, clang, centos-gpu, website, unix-cpu, centos-cpu, miscellaneous, windows-gpu, sanity, windows-cpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@wkcn wkcn changed the title Call Stop when custom op released Call the function Stop when custom op released Aug 31, 2020
@wkcn wkcn closed this Aug 31, 2020
@wkcn
Copy link
Member Author

wkcn commented Aug 31, 2020

In src/initialize.cc, LibraryInitializer::atfork_prepare() calls CustomOperator::Get()->Stop();.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Autograd throws an exception that was not caught in MXNet 1.6
2 participants