Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x]Fix the monitor_callback invalid issue during calibration with variable input shapes #18705

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

ciyongch
Copy link
Contributor

Description

Backport #18632 to addressed the calibration invalid issue with variable input shapes, while keep the code coverage check functionality for 1.x branch.

@szha @ChaiBapchya @TaoLv

@ciyongch ciyongch requested a review from szha as a code owner July 14, 2020 04:37
@mxnet-bot
Copy link

Hey @ciyongch , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, edge, miscellaneous, unix-gpu, sanity, centos-cpu, clang, website, windows-gpu, windows-cpu, unix-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ciyongch
Copy link
Contributor Author

@leezu @szha as the codecov is not a blocker for the PR, should I turn off this check for 1.x branch or just leave it as it is now?

@szha szha merged commit 5cdefeb into apache:v1.x Jul 15, 2020
@szha
Copy link
Member

szha commented Jul 15, 2020

We can leave it as is.

@ciyongch ciyongch deleted the v1.x_nomitor branch July 16, 2020 00:54
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants