This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.7] Backport Gluon Activations Fix #18370 #18700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sxjscience , Thanks for submitting the PR
CI supported jobs: [unix-gpu, miscellaneous, website, unix-cpu, edge, centos-cpu, windows-cpu, clang, windows-gpu, sanity, centos-gpu] Note: |
|
@ciyongch I will also need this fix about Gluon Activations in Numpy. |
szha
approved these changes
Jul 13, 2020
ciyongch
approved these changes
Jul 14, 2020
|
@ciyongch Would you help review or merge this? |
|
Hi @TaoLv , please help to merge the PR. Thanks. |
TaoLv
approved these changes
Jul 14, 2020
|
@TaoLv @sxjscience Missing in v1.x branch. Intentional? |
|
No
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Chaitanya Prakash Bapat <[email protected]>
Sent: Saturday, September 19, 2020 9:37:40 PM
To: apache/incubator-mxnet <[email protected]>
Cc: Xingjian SHI <[email protected]>; Mention <[email protected]>
Subject: Re: [apache/incubator-mxnet] [v1.7] Backport Gluon Activations Fix #18370 (#18700)
@TaoLv<https://github.com/TaoLv> @sxjscience<https://github.com/sxjscience> Missing in v1.x branch. Intentional?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18700 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABHQH3QXCZUETTM7A726OHTSGWBJJANCNFSM4OY3GNBA>.
|
|
Can we cherry-pick this into v1.x then? So that we can ensure it gets into v1.8 as well? |
|
@ChaiBapchya Yes, feel free to go ahead and pick it to v1.x. |
leezu
pushed a commit
to leezu/mxnet
that referenced
this pull request
Oct 1, 2020
samskalicky
pushed a commit
that referenced
this pull request
Oct 2, 2020
* * Fix einsum gradient (#18482) * [v1.7.x] Backport PRs of numpy features (#18653) * add zero grad for npi_unique (#18080) * fix np.clip scalar input case (#17788) * fix true_divide (#18393) Co-authored-by: Hao Jin <[email protected]> Co-authored-by: Xi Wang <[email protected]> * [v1.7.x] backport mixed type binary ops to v1.7.x (#18649) * Fix Windows GPU CI (#17962) Update Windows CI to use VS 2019 and enable x64 bit toolchain. Previously we are using an older 32 bit toolchain causing OOM errors during linking. Switching to x64 bit toolchain on the older VS version previously used by the CI was attempted in #17912 and did not work. Update to Cuda 10.2 as it is required by VS 2019. Switch to ninja-build on Windows to speed up build as ninja-build is now preinstalled. Remove logic to install cmake 3.16 on every PR as cmake 3.17 is now preinstalled. Add build retrials due to cuda thrust + VS2019 flakyness. Co-authored-by: vexilligera <[email protected]> * backport mixed type Co-authored-by: Leonard Lausen <[email protected]> Co-authored-by: vexilligera <[email protected]> * revise activations (#18700) * [v1.6] Fix the monitor_callback invalid issue during calibration with variable input shapes (#18632) (#18703) * Fix the monitor_callback invalid issue during calibration with variable input shapes * retrigger CI * Add UT for monitor check and disable codecov Co-authored-by: Tao Lv <[email protected]> * Fail build_windows.py if all retries failed (#18177) * Update to thrust 1.9.8 on Windows (#18218) * Update to thrust 1.9.8 on Windows * Remove debug logic * Re-enable build retries on MSVC (#18230) Updating thrust alone did not help. Similar issues (though less often) still occur with updated thrust, and also with nvidia cub. Tracked upstream at NVIDIA/thrust#1090 Co-authored-by: Ke Han <[email protected]> Co-authored-by: Xingjian Shi <[email protected]> Co-authored-by: Hao Jin <[email protected]> Co-authored-by: Xi Wang <[email protected]> Co-authored-by: Yijun Chen <[email protected]> Co-authored-by: vexilligera <[email protected]> Co-authored-by: ciyong <[email protected]> Co-authored-by: Tao Lv <[email protected]>
samskalicky
pushed a commit
to samskalicky/incubator-mxnet
that referenced
this pull request
Oct 2, 2020
* * Fix einsum gradient (apache#18482) * [v1.7.x] Backport PRs of numpy features (apache#18653) * add zero grad for npi_unique (apache#18080) * fix np.clip scalar input case (apache#17788) * fix true_divide (apache#18393) Co-authored-by: Hao Jin <[email protected]> Co-authored-by: Xi Wang <[email protected]> * [v1.7.x] backport mixed type binary ops to v1.7.x (apache#18649) * Fix Windows GPU CI (apache#17962) Update Windows CI to use VS 2019 and enable x64 bit toolchain. Previously we are using an older 32 bit toolchain causing OOM errors during linking. Switching to x64 bit toolchain on the older VS version previously used by the CI was attempted in apache#17912 and did not work. Update to Cuda 10.2 as it is required by VS 2019. Switch to ninja-build on Windows to speed up build as ninja-build is now preinstalled. Remove logic to install cmake 3.16 on every PR as cmake 3.17 is now preinstalled. Add build retrials due to cuda thrust + VS2019 flakyness. Co-authored-by: vexilligera <[email protected]> * backport mixed type Co-authored-by: Leonard Lausen <[email protected]> Co-authored-by: vexilligera <[email protected]> * revise activations (apache#18700) * [v1.6] Fix the monitor_callback invalid issue during calibration with variable input shapes (apache#18632) (apache#18703) * Fix the monitor_callback invalid issue during calibration with variable input shapes * retrigger CI * Add UT for monitor check and disable codecov Co-authored-by: Tao Lv <[email protected]> * Fail build_windows.py if all retries failed (apache#18177) * Update to thrust 1.9.8 on Windows (apache#18218) * Update to thrust 1.9.8 on Windows * Remove debug logic * Re-enable build retries on MSVC (apache#18230) Updating thrust alone did not help. Similar issues (though less often) still occur with updated thrust, and also with nvidia cub. Tracked upstream at NVIDIA/thrust#1090 Co-authored-by: Ke Han <[email protected]> Co-authored-by: Xingjian Shi <[email protected]> Co-authored-by: Hao Jin <[email protected]> Co-authored-by: Xi Wang <[email protected]> Co-authored-by: Yijun Chen <[email protected]> Co-authored-by: vexilligera <[email protected]> Co-authored-by: ciyong <[email protected]> Co-authored-by: Tao Lv <[email protected]>
samskalicky
added a commit
that referenced
this pull request
Oct 3, 2020
* * Fix einsum gradient (#18482) * [v1.7.x] Backport PRs of numpy features (#18653) * add zero grad for npi_unique (#18080) * fix np.clip scalar input case (#17788) * fix true_divide (#18393) Co-authored-by: Hao Jin <[email protected]> Co-authored-by: Xi Wang <[email protected]> * [v1.7.x] backport mixed type binary ops to v1.7.x (#18649) * Fix Windows GPU CI (#17962) Update Windows CI to use VS 2019 and enable x64 bit toolchain. Previously we are using an older 32 bit toolchain causing OOM errors during linking. Switching to x64 bit toolchain on the older VS version previously used by the CI was attempted in #17912 and did not work. Update to Cuda 10.2 as it is required by VS 2019. Switch to ninja-build on Windows to speed up build as ninja-build is now preinstalled. Remove logic to install cmake 3.16 on every PR as cmake 3.17 is now preinstalled. Add build retrials due to cuda thrust + VS2019 flakyness. Co-authored-by: vexilligera <[email protected]> * backport mixed type Co-authored-by: Leonard Lausen <[email protected]> Co-authored-by: vexilligera <[email protected]> * revise activations (#18700) * [v1.6] Fix the monitor_callback invalid issue during calibration with variable input shapes (#18632) (#18703) * Fix the monitor_callback invalid issue during calibration with variable input shapes * retrigger CI * Add UT for monitor check and disable codecov Co-authored-by: Tao Lv <[email protected]> * Fail build_windows.py if all retries failed (#18177) * Update to thrust 1.9.8 on Windows (#18218) * Update to thrust 1.9.8 on Windows * Remove debug logic * Re-enable build retries on MSVC (#18230) Updating thrust alone did not help. Similar issues (though less often) still occur with updated thrust, and also with nvidia cub. Tracked upstream at NVIDIA/thrust#1090 Co-authored-by: Ke Han <[email protected]> Co-authored-by: Xingjian Shi <[email protected]> Co-authored-by: Hao Jin <[email protected]> Co-authored-by: Xi Wang <[email protected]> Co-authored-by: Yijun Chen <[email protected]> Co-authored-by: vexilligera <[email protected]> Co-authored-by: ciyong <[email protected]> Co-authored-by: Tao Lv <[email protected]> Co-authored-by: Leonard Lausen <[email protected]> Co-authored-by: Ke Han <[email protected]> Co-authored-by: Xingjian Shi <[email protected]> Co-authored-by: Hao Jin <[email protected]> Co-authored-by: Xi Wang <[email protected]> Co-authored-by: Yijun Chen <[email protected]> Co-authored-by: vexilligera <[email protected]> Co-authored-by: ciyong <[email protected]> Co-authored-by: Tao Lv <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.