-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[mxnet 2.0] deprecate gluon.model_zoo, image.detection #18480
base: master
Are you sure you want to change the base?
Conversation
Hey @zhreshold , Thanks for submitting the PR
CI supported jobs: [sanity, clang, windows-gpu, windows-cpu, miscellaneous, website, unix-cpu, centos-cpu, unix-gpu, centos-gpu, edge] Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up. A couple changes please:
- add deprecation warning to 1.x. the warning should only when model zoo function is invoked.
- move the current model zoo to test utils and update related tests in master.
Also, the lint needs to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to remove the model_zoo api for mxnet 2.0? Many unit tests rely on downloading a pretrained model (e.g. quantization, AMP). Removing the API makes it harder for those tests.
I guess it's fine. The existing models in the model zoo are not trained with the numpy API anyway |
Description
Deprecate gluon model zoo, image.detection in favor of gluon toolkits and gluon transform functions, respectively.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments