Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Backport: Fix PyPI Packages and Python Docker Images nightly release (#18222) #18432

Merged
merged 1 commit into from
May 29, 2020

Conversation

apeforest
Copy link
Contributor

  • remove OS from s3 library path

  • fix bash script run commands

  • Revert "remove OS from s3 library path"

This reverts commit 2665113.

  • hardcode s3 path for upload/download of binaries

Co-authored-by: Ubuntu [email protected]

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

)

* remove OS from s3 library path

* fix bash script run commands

* Revert "remove OS from s3 library path"

This reverts commit 2665113.

* hardcode s3 path for upload/download of binaries

Co-authored-by: Ubuntu <[email protected]>
@apeforest apeforest requested a review from szha as a code owner May 29, 2020 06:00
@mxnet-bot
Copy link

Hey @apeforest , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, windows-gpu, centos-gpu, miscellaneous, website, edge, sanity, centos-cpu, unix-gpu, clang, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@apeforest
Copy link
Contributor Author

@leezu @ciyongch Please help to review. Thanks

@apeforest apeforest changed the title [Backport] Fix PyPI Packages and Python Docker Images nightly release (#18222) [v1.x] Backport: Fix PyPI Packages and Python Docker Images nightly release (#18222) May 29, 2020
@ciyongch
Copy link
Contributor

Seems there's some issue with CI on this branch, can you help to take a check as well? Thanks!

[2020-05-29T08:56:46.595Z] + ln -s /usr/bin/ninja-build /usr/bin/ninja

[2020-05-29T08:56:46.595Z] ln: failed to create symbolic link '/usr/bin/ninja': File exists

[2020-05-29T08:56:47.515Z] The command '/bin/sh -c /work/centos7_core.sh' returned a non-zero code: 1

@leezu
Copy link
Contributor

leezu commented May 29, 2020

@mxnet-bot run ci [centos-cpu, centos-gpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu, centos-gpu, unix-gpu]

@leezu leezu merged commit 3ee8e00 into apache:v1.x May 29, 2020
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
) (apache#18432)

* remove OS from s3 library path

* fix bash script run commands

* Revert "remove OS from s3 library path"

This reverts commit 2665113.

* hardcode s3 path for upload/download of binaries

Co-authored-by: Ubuntu <[email protected]>

Co-authored-by: Manu Seth <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants